Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Support lifecycle tags filter in aws_s3_bucket #13680

Closed

Conversation

kjmkznr
Copy link
Contributor

@kjmkznr kjmkznr commented Apr 15, 2017

Enhance aws_s3_bucket resource, lifecycle_rule.

  • Add tags filter in lifecycle_rule
  • Change prefix filter to optional

https://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketPUTlifecycle.html

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSS3Bucket_Lifecycle'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/16 02:40:19 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSS3Bucket_Lifecycle -timeout 120m
=== RUN   TestAccAWSS3Bucket_Lifecycle
--- PASS: TestAccAWSS3Bucket_Lifecycle (124.24s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    124.255s

Link #13473, #12830

@bdashrad
Copy link

bdashrad commented May 4, 2017

What needs to happen to get this merged? This will fixe the issue we have in #12830.

@apenney
Copy link

apenney commented May 31, 2017

Any chance of getting this merged? This is really hurting us and just hanging out here for ages.

@ChristopheSchmitz
Copy link

Would be great to merge that, yes!

@kjmkznr kjmkznr changed the title provider/aws: Ssupport lifecycle tags filter in aws_s3_bucket provider/aws: Support lifecycle tags filter in aws_s3_bucket Jun 5, 2017
@scottrhoyt
Copy link

We'd love to see this feature!

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants