provider/aws: Add key_name_prefix argument to aws_key_pair resource

[nicksantamaria]

What does this PR do?

This PR adds a new argument to the aws_key_pair resource called key_name_prefix. This behaves in the same way as name_prefix seen on several other AWS resources.

Any background context you want to provide?

It is worth noting that the current key_name argument will auto-generate an identifier if omitted. This was documented incorrectly which lead me down the path of implementing this (documentation now fixed in #9992).

What are the relevant tickets?

I could not find an existing issue requesting this enhancement.

Checklist

Acceptance test coverage of new behaviour
Implemented - see builtin/providers/aws/resource_aws_key_pair_test.go

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=testAccCheckAWSKeyPair_namePrefix'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/09 23:40:07 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=testAccCheckAWSKeyPair_namePrefix -timeout 120m
PASS
ok  	github.com/nicksantamaria/terraform/builtin/providers/aws	0.019s

Documentation updates
Implemented - see website/source/docs/providers/aws/r/key_pair.html.markdown

Well-formed Code
make fmt does not show any failures.

[stack72]

Hi @nicksantamaria

This is looking good - one question within

It seems like that acceptance tests didn't run here - can you check them again and drop the _key suffix?

P.

[stack72]

Any reason why you chose 100 as the max length here?

[nicksantamaria]

This matches the validation for the name_prefix argument for aws_security_group resource. I have double-checked and the maximum key pair name length is 255 characters.

[stack72]

Got it :)

[stack72]

This LGTM! Thanks for the work on this :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSKeyPair_'                                                               ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/09 15:26:41 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSKeyPair_ -timeout 120m
=== RUN   TestAccAWSKeyPair_importBasic
--- PASS: TestAccAWSKeyPair_importBasic (53.48s)
=== RUN   TestAccAWSKeyPair_basic
--- PASS: TestAccAWSKeyPair_basic (30.77s)
=== RUN   TestAccAWSKeyPair_generatedName
--- PASS: TestAccAWSKeyPair_generatedName (22.10s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    106.368s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.