provider/aws: Add support for reference_name to aws_route53_health_check #9737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack72
force-pushed
the
b-aws-r53-healthcheck-reference_name
branch
from
0cc0dab to
ebf3247
Compare
catsby
approved these changes
Oct 31, 2016
| if v, ok := d.GetOk("reference_name"); ok { | ||
| callerRef = strings.Join([]string{ | ||
| v.(string), "-", callerRef, | ||
| }, "") |
There was a problem hiding this comment.
minor nit: callerRef = fmt.Sprintf("%s-%s", v.(string), callerRef)
There was a problem hiding this comment.
you are correct - this is better :)
Fixes #8679 The CallerReference attribute we passed to AWS in route53_health_checks was `time.Now().Format(time.RFC3339Nano)` When creating multiple resources with the Count meta-parameter, this was causing issues as follows: ``` * aws_route53_health_check.healthstate.0: HealthCheckAlreadyExists: A different health check has already been created with the specified caller reference. ``` We have now exposed a new attribute called `reference_name` that can be set to pass multiple resources to the request ``` make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRoute53HealthCheck_' 130 ↵ ✹ ==> Cecking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/10/31 10:41:07 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRoute53HealthCheck_ -timeout 120m === RUN TestAccAWSRoute53HealthCheck_importBasic --- PASS: TestAccAWSRoute53HealthCheck_importBasic (17.08s) === RUN TestAccAWSRoute53HealthCheck_basic --- PASS: TestAccAWSRoute53HealthCheck_basic (28.17s) === RUN TestAccAWSRoute53HealthCheck_withSearchString --- PASS: TestAccAWSRoute53HealthCheck_withSearchString (28.07s) === RUN TestAccAWSRoute53HealthCheck_withChildHealthChecks --- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (20.71s) === RUN TestAccAWSRoute53HealthCheck_IpConfig --- PASS: TestAccAWSRoute53HealthCheck_IpConfig (16.09s) === RUN TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck --- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (22.42s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 132.568s ```
stack72
force-pushed
the
b-aws-r53-healthcheck-reference_name
branch
from
ebf3247 to
e7c682d
Compare
gusmat
pushed a commit
to gusmat/terraform
that referenced
this pull request
Dec 6, 2016
…eck (hashicorp#9737) Fixes hashicorp#8679 The CallerReference attribute we passed to AWS in route53_health_checks was `time.Now().Format(time.RFC3339Nano)` When creating multiple resources with the Count meta-parameter, this was causing issues as follows: ``` * aws_route53_health_check.healthstate.0: HealthCheckAlreadyExists: A different health check has already been created with the specified caller reference. ``` We have now exposed a new attribute called `reference_name` that can be set to pass multiple resources to the request ``` make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRoute53HealthCheck_' 130 ↵ ✹ ==> Cecking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/10/31 10:41:07 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRoute53HealthCheck_ -timeout 120m === RUN TestAccAWSRoute53HealthCheck_importBasic --- PASS: TestAccAWSRoute53HealthCheck_importBasic (17.08s) === RUN TestAccAWSRoute53HealthCheck_basic --- PASS: TestAccAWSRoute53HealthCheck_basic (28.17s) === RUN TestAccAWSRoute53HealthCheck_withSearchString --- PASS: TestAccAWSRoute53HealthCheck_withSearchString (28.07s) === RUN TestAccAWSRoute53HealthCheck_withChildHealthChecks --- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (20.71s) === RUN TestAccAWSRoute53HealthCheck_IpConfig --- PASS: TestAccAWSRoute53HealthCheck_IpConfig (16.09s) === RUN TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck --- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (22.42s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 132.568s ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8679