Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Rundeck provider: scheduler #9449

Merged
merged 2 commits into from
Dec 13, 2016

Conversation

samber
Copy link
Contributor

@samber samber commented Oct 19, 2016

Hi guys,

Rundeck provider cannot create scheduled jobs (understand cronjobs).
This PR make it possible ;-)

Also upgraded go-rundeck library.

@samber samber force-pushed the feat--rundeck-schedule branch from aadea87 to bb751e6 Compare October 19, 2016 12:23
@samber
Copy link
Contributor Author

samber commented Oct 24, 2016

ping @apparentlymart @Freyskeyd ;-)

@Freyskeyd
Copy link

LGTM 👌

@nanoz
Copy link

nanoz commented Oct 24, 2016

Oh, nice ! I really need this :)

@stack72
Copy link
Contributor

stack72 commented Dec 13, 2016

Hi @samber

Sorry taken for the time taken to getting this up and tested! Thanks so much for this work :)

% make testacc TEST=./builtin/providers/rundeck
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/13 12:00:04 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/rundeck -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccJob_basic
--- PASS: TestAccJob_basic (1.73s)
=== RUN   TestAccPrivateKey_basic
--- PASS: TestAccPrivateKey_basic (0.32s)
=== RUN   TestAccProject_basic
--- PASS: TestAccProject_basic (0.45s)
=== RUN   TestAccPublicKey_basic
--- PASS: TestAccPublicKey_basic (1.48s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/rundeck	3.997s

This LGTM!

Paul

@stack72 stack72 merged commit 88faa1b into hashicorp:master Dec 13, 2016
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants