provider/postgresql: Create provider for postgresql extensions

[samdunne]

This change adds support for installing postgresql extensions on a
postgresql server.

[jen20]

cc @sean- for review

[samdunne]

@jen20 @sean- tests are fixed now

[stack72]

Hi @samdunne

Thanks for the work here. I think this needs a few changes:

1. It needs added to provider.go or it can't be used
2. We need to add the documentation link to the postgres.erb file (for the sidebar)
3. Why is there no Read func included? How can we guarantee that the operation has been a success?

Paul

[stack72]

Why does it call the SQLRoleRead func?

[stack72]

ping @samdunne

[samdunne]

Oops. This fell through the cracks a bit. Will rectify and commit today. Apologies @stack72

[stack72]

pinging in again LOL :)

[samdunne]

@stack72 sorry my head is like a sieve the last week. Added changes there. Pretty sure that's it

[stack72]

Hi @samdunne

This LGTM now :) I had to make 1 small change (to fix a test) but they are green now

% make testacc TEST=./builtin/providers/postgresql                                                                                                                                                      2 ↵
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/03 12:06:22 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/postgresql -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccPostgresqlDatabase_Basic
--- PASS: TestAccPostgresqlDatabase_Basic (1.49s)
=== RUN   TestAccPostgresqlDatabase_DefaultOwner
--- PASS: TestAccPostgresqlDatabase_DefaultOwner (0.53s)
=== RUN   TestAccPostgresqlExtension_Basic
--- PASS: TestAccPostgresqlExtension_Basic (0.06s)
=== RUN   TestAccPostgresqlRole_Basic
--- PASS: TestAccPostgresqlRole_Basic (0.16s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/postgresql 2.246s

[samdunne]

\o/ thanks @stack72

[sean-]

@samdunne Have you had a chance to poke at the extension updates that landed in 0.8?

[samdunne]

@sean- I haven't had a chance yet. Will give it a try this evening :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.