Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Make encryption in Aurora instances computed-only #9060

Merged
merged 1 commit into from
Sep 26, 2016

Conversation

radeksimko
Copy link
Member

This is fixing two bugs:

  1. The KMS Key ID was never read back from the API
  2. It is only possible to set encryption (and hence KMS key ID too) on the cluster level, it is impossible to have a mixture of encrypted & unencrypted instances in the same cluster, as described in the documentation. Even though these fields have been marked as Optional, they were not actually used anywhere in any API calls when specified by the user.

Test plan

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRDSClusterInstance'
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRDSClusterInstance -timeout 120m
=== RUN   TestAccAWSRDSClusterInstance_importBasic
--- PASS: TestAccAWSRDSClusterInstance_importBasic (803.05s)
=== RUN   TestAccAWSRDSClusterInstance_basic
--- PASS: TestAccAWSRDSClusterInstance_basic (959.59s)
=== RUN   TestAccAWSRDSClusterInstance_kmsKey
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (844.50s)
=== RUN   TestAccAWSRDSClusterInstance_disappears
2016/09/26 18:22:50 Request body type has been overwritten. May cause race conditions
--- PASS: TestAccAWSRDSClusterInstance_disappears (979.28s)
=== RUN   TestAccAWSRDSClusterInstance_withInstanceEnhancedMonitor
--- PASS: TestAccAWSRDSClusterInstance_withInstanceEnhancedMonitor (997.34s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    4583.792s

@stack72
Copy link
Contributor

stack72 commented Sep 26, 2016

LGTM! nice work @radeksimko :)

@stack72 stack72 merged commit bdb9156 into hashicorp:master Sep 26, 2016
@radeksimko radeksimko deleted the b-aws-aurora-encryption branch September 26, 2016 18:49
@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants