provider/aws: Add support for tags to aws_cloudfront_distribution

[stack72]

Fixes #8959

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSCloudFrontDistribution_S3OriginWithTags'                                           2 ↵ ✹
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/23 16:30:31 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSCloudFrontDistribution_S3OriginWithTags -timeout 120m
=== RUN   TestAccAWSCloudFrontDistribution_S3OriginWithTags
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (1234.66s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    1234.680s

[catsby]

if tagErr is non-nil, seems like there would be a decent chance that tagResp is nil, does that sound right? We may want to guard here for a nil response and nil pointer dereference

[stack72]

We can guard against it no worries at all - I was just going with the API description:

// The returned result of the corresponding request.
type ListTagsForResourceOutput struct {
    _ struct{} `type:"structure" payload:"Tags"`

    // A complex type that contains zero or more Tag elements.
    Tags *Tags `type:"structure" required:"true"`
}

Have pushed the guard :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.