Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for cloudwatch_logging_options to AWS Kinesis Firehose Delivery Streams #8671

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Sep 6, 2016

Fixes #7152

Adding support for CloudWatch Logging to Firehose as per the
instructions here -
http://docs.aws.amazon.com/firehose/latest/dev/monitoring-with-cloudwatch-logs.html

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSKinesisFirehoseDeliveryStream_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/07 23:02:35 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v
-run=TestAccAWSKinesisFirehoseDeliveryStream_ -timeout 120m
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3basic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basic (273.48s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging (200.48s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates (338.16s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates (835.44s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates (2289.74s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws
3937.351s

@stack72 stack72 changed the title provider/aws: Add support for cloudwatch_logging_options to AWS Kinesis Firehose Delivery Streams [WIP] provider/aws: Add support for cloudwatch_logging_options to AWS Kinesis Firehose Delivery Streams Sep 6, 2016
Kinesis Firehose Delivery Streams

Fixes #7152

Adding support for CloudWatch Logging to Firehose as per the
instructions here -
http://docs.aws.amazon.com/firehose/latest/dev/monitoring-with-cloudwatch-logs.html

```

```
@stack72 stack72 force-pushed the f-aws-firehose-cloudwatch branch from a889e6a to d81cbdb Compare September 7, 2016 22:32
@stack72 stack72 changed the title [WIP] provider/aws: Add support for cloudwatch_logging_options to AWS Kinesis Firehose Delivery Streams provider/aws: Add support for cloudwatch_logging_options to AWS Kinesis Firehose Delivery Streams Sep 7, 2016
@jen20
Copy link
Contributor

jen20 commented Sep 22, 2016

Looks good to me!

@stack72 stack72 merged commit 27a89ff into master Sep 22, 2016
@stack72 stack72 deleted the f-aws-firehose-cloudwatch branch September 22, 2016 09:01
@jaygorrell
Copy link

jaygorrell commented Nov 14, 2016

@stack72 How does this work in cases like Redshift where multiple streams are created? For example, see http://docs.aws.amazon.com/firehose/latest/dev/monitoring-with-cloudwatch-logs.html

EDIT
Disregard the above. For anyone else stumbling onto this because of the same issue, it seems that you just need to specify the logging on each component. The API docs such as Boto's here helps clarify this more than the Console settings I linked above.

@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for encryption and logging to Amazon Kinesis Firehose
3 participants