provider/aws: Refresh aws_elasticsearch_domain from state when ResourceNotFoundException
#8643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RecordNotFoundException Fixes #3967 When an ElasticSearch domain has been deleted outside of Terraform, the next Terraform operation would return the following: ``` * aws_elasticsearch_domain.curvelogic_es: ResourceNotFoundException: * Domain not found: curvelogic-es status code: 409, request id: 6e4b2371-8e1a-11e5-bd07-7741b705d65c ``` We now refresh the resource from state when it is no longer found
| @@ -256,6 +256,11 @@ func resourceAwsElasticSearchDomainRead(d *schema.ResourceData, meta interface{} | |||
| DomainName: aws.String(d.Get("domain_name").(string)), | |||
| }) | |||
| if err != nil { | |||
| if ec2err, ok := err.(awserr.Error); ok && ec2err.Code() == "RecordNotFoundException" { | |||
There was a problem hiding this comment.
Are you sure this is the right error code?
the API reference says "ResourceNotFoundException", i.e. Resource not Record
radeksimko
added
bug
provider/aws
waiting-response
stack72
changed the title
aws_elasticsearch_domain from state when RecordNotFoundExceptionaws_elasticsearch_domain from state when ResourceNotFoundException
|
LGTM. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3967
When an ElasticSearch domain has been deleted outside of Terraform, the
next Terraform operation would return the following:
We now refresh the resource from state when it is no longer found