Aurora Enhanced monitoring support

[arcadiatea]

Add Enable Enhanced Monitoring feature to Aurora instance

[stack72]

Can you rename this to be TestAccAWSRDSCluster_withInstanceEnhancedMonitor so that a single call will run all tests?

[stack72]

Hi @arcadiatea

Thanks so much for the PR here. Left you 1 request on the naming

thanks

Paul

[stack72]

Hi @arcadiatea

So the tests are all named as I mentioned - the internal functions for the tests (e.g. destroy, exists) are named with the lowercase style prefix

P.

[stack72]

Hi @arcadiatea

just a FYI, I tried to run the tests here:

    testing.go:264: Step 0 error: Error loading configuration: Error loading /var/folders/gd/yv86v7pd1cd5dpzjrw8702k00000gn/T/tf-test105270374/main.tf: Error reading config for aws_rds_cluster_instance[cluster_instances]: aws_iam_role.tf_enhanced_monitor_role: resource variables must be three parts: TYPE.NAME.ATTR in:

        ${aws_iam_role.tf_enhanced_monitor_role}
FAIL
exit status 1
FAIL    github.com/hashicorp/terraform/builtin/providers/aws    3791.034s
make: *** [testacc] Error 1

[arcadiatea]

@stack72 I have a fix ready. I am running test

[stack72]

👍

[stack72]

Hi @arcadiatea

This LGTM now :)

Thanks!

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRDSClusterInstance_'                                   1 ↵ ✹
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/09 13:57:50 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRDSClusterInstance_ -timeout 120m
=== RUN   TestAccAWSRDSClusterInstance_importBasic
--- PASS: TestAccAWSRDSClusterInstance_importBasic (850.20s)
=== RUN   TestAccAWSRDSClusterInstance_basic
--- PASS: TestAccAWSRDSClusterInstance_basic (825.66s)
=== RUN   TestAccAWSRDSClusterInstance_kmsKey
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (893.25s)
=== RUN   TestAccAWSRDSClusterInstance_disappears
--- PASS: TestAccAWSRDSClusterInstance_disappears (850.60s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    3419.737s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.