Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for uploading blobs to azure storage from local source #7994

Merged
merged 1 commit into from
Aug 8, 2016
Merged

Adds support for uploading blobs to azure storage from local source #7994

merged 1 commit into from
Aug 8, 2016

Conversation

ryanmoran
Copy link
Contributor

  • adds "source", "parallelism", and "attempts" fields
  • supports both block and page type blobs
  • uploads run concurrently
  • page blobs skip empty byte ranges to efficiently upload large sparse
    files
  • "source" expects an absolute path to a file on the local file
    system
  • "parallelism" expects an integer value that indicates the number of
    workers per CPU core to run for concurrent uploads
  • "attempts" expects an integer value for number of attempts to make per
    page or block when uploading

- adds "source", "parallelism", and "attempts" fields
- supports both block and page type blobs
- uploads run concurrently
- page blobs skip empty byte ranges to efficiently upload large sparse
  files

- "source" expects an absolute path to a file on the local file
  system
- "parallelism" expects an integer value that indicates the number of
  workers per CPU core to run for concurrent uploads
- "attempts" expects an integer value for number of attempts to make per
  page or block when uploading

Signed-off-by: Raina Masand <[email protected]>
@stack72
Copy link
Contributor

stack72 commented Aug 8, 2016

Hi @ryanmoran

This is a great PR - thanks so much for the work here :)

I am going to manually merge this - it needs a few pieces of documentation to help the users out :)

% make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMStorageBlob'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/08 15:21:30 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMStorageBlob -timeout 120m
=== RUN   TestAccAzureRMStorageBlob_basic
--- PASS: TestAccAzureRMStorageBlob_basic (214.46s)
=== RUN   TestAccAzureRMStorageBlobBlock_source
--- PASS: TestAccAzureRMStorageBlobBlock_source (283.22s)
=== RUN   TestAccAzureRMStorageBlobPage_source
--- PASS: TestAccAzureRMStorageBlobPage_source (347.04s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    844.734s

Paul

@stack72 stack72 merged commit 85b551a into hashicorp:master Aug 8, 2016
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants