provider/azurerm: add traffic manager resources #7826

pmcatominey · 2016-07-27T10:58:56Z

TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMTrafficManager -timeout 120m
=== RUN   TestAccAzureRMTrafficManagerEndpoint_basic
--- PASS: TestAccAzureRMTrafficManagerEndpoint_basic (163.31s)
=== RUN   TestAccAzureRMTrafficManagerEndpoint_basicDisableExternal
--- PASS: TestAccAzureRMTrafficManagerEndpoint_basicDisableExternal (179.61s)
=== RUN   TestAccAzureRMTrafficManagerEndpoint_updateWeight
--- PASS: TestAccAzureRMTrafficManagerEndpoint_updateWeight (245.83s)
=== RUN   TestAccAzureRMTrafficManagerEndpoint_updatePriority
--- PASS: TestAccAzureRMTrafficManagerEndpoint_updatePriority (101.39s)
=== RUN   TestAccAzureRMTrafficManagerEndpoint_nestedEndpoints
--- PASS: TestAccAzureRMTrafficManagerEndpoint_nestedEndpoints (71.72s)
=== RUN   TestAccAzureRMTrafficManagerProfile_weighted
--- PASS: TestAccAzureRMTrafficManagerProfile_weighted (78.26s)
=== RUN   TestAccAzureRMTrafficManagerProfile_performance
--- PASS: TestAccAzureRMTrafficManagerProfile_performance (85.58s)
=== RUN   TestAccAzureRMTrafficManagerProfile_priority
--- PASS: TestAccAzureRMTrafficManagerProfile_priority (86.91s)
=== RUN   TestAccAzureRMTrafficManagerProfile_withTags
--- PASS: TestAccAzureRMTrafficManagerProfile_withTags (103.82s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    1116.543s

stack72 · 2016-07-27T11:04:11Z

Hi @pmcatominey

Thanks so much for the PR here - will run the tests and have a look through :)

P.

stack72 · 2016-07-27T11:07:26Z

builtin/providers/azurerm/resource_arm_traffic_manager_endpoint.go

+	endpoint := *resp.Properties
+
+	d.Set("name", resp.Name)
+	d.Set("endpoint_status", *endpoint.EndpointStatus)


We don't need to dereference before passing into d.Set - infact, it's safer if we don't, it takes care of the check

The resource now takes the short type for example azureEndpoints instead of the long form Microsoft.Network/TrafficManagerProfiles/azureEndpoints. ``` TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMTrafficManagerEndpoint -timeout 120m === RUN TestAccAzureRMTrafficManagerEndpoint_basic --- PASS: TestAccAzureRMTrafficManagerEndpoint_basic (179.72s) === RUN TestAccAzureRMTrafficManagerEndpoint_basicDisableExternal --- PASS: TestAccAzureRMTrafficManagerEndpoint_basicDisableExternal (171.36s) === RUN TestAccAzureRMTrafficManagerEndpoint_updateWeight --- PASS: TestAccAzureRMTrafficManagerEndpoint_updateWeight (167.24s) === RUN TestAccAzureRMTrafficManagerEndpoint_updatePriority --- PASS: TestAccAzureRMTrafficManagerEndpoint_updatePriority (192.91s) === RUN TestAccAzureRMTrafficManagerEndpoint_nestedEndpoints --- PASS: TestAccAzureRMTrafficManagerEndpoint_nestedEndpoints (111.18s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 822.534s ```

…esources ``` TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMTrafficManager -timeout 120m === RUN TestAccAzureRMTrafficManagerEndpoint_basic --- PASS: TestAccAzureRMTrafficManagerEndpoint_basic (176.08s) === RUN TestAccAzureRMTrafficManagerEndpoint_basicDisableExternal --- PASS: TestAccAzureRMTrafficManagerEndpoint_basicDisableExternal (172.28s) === RUN TestAccAzureRMTrafficManagerEndpoint_updateWeight --- PASS: TestAccAzureRMTrafficManagerEndpoint_updateWeight (148.97s) === RUN TestAccAzureRMTrafficManagerEndpoint_updatePriority --- PASS: TestAccAzureRMTrafficManagerEndpoint_updatePriority (101.18s) === RUN TestAccAzureRMTrafficManagerEndpoint_nestedEndpoints --- PASS: TestAccAzureRMTrafficManagerEndpoint_nestedEndpoints (88.33s) === RUN TestAccAzureRMTrafficManagerProfile_weighted --- PASS: TestAccAzureRMTrafficManagerProfile_weighted (80.92s) === RUN TestAccAzureRMTrafficManagerProfile_performance --- PASS: TestAccAzureRMTrafficManagerProfile_performance (82.98s) === RUN TestAccAzureRMTrafficManagerProfile_priority --- PASS: TestAccAzureRMTrafficManagerProfile_priority (81.07s) === RUN TestAccAzureRMTrafficManagerProfile_withTags --- PASS: TestAccAzureRMTrafficManagerProfile_withTags (102.50s) PASS ok github.com/hashicorp/terraform/builtin/providers/azurerm 1034.458s ```

pmcatominey · 2016-07-29T09:19:16Z

Removed the dereferences for top level attributes, they remain in place for properties of sets as it was cleaner than checking types.

stack72 · 2016-07-30T00:21:55Z

Hi @pmcatominey

This LGTM now :) I am going to hold off merging this until we finish cutting RC4 though - so bare with me for a day or 2

% make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMTrafficManager'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMTrafficManager -timeout 120m
=== RUN   TestAccAzureRMTrafficManagerEndpoint_basic
--- PASS: TestAccAzureRMTrafficManagerEndpoint_basic (137.88s)
=== RUN   TestAccAzureRMTrafficManagerEndpoint_basicDisableExternal
--- PASS: TestAccAzureRMTrafficManagerEndpoint_basicDisableExternal (182.37s)
=== RUN   TestAccAzureRMTrafficManagerEndpoint_updateWeight
--- PASS: TestAccAzureRMTrafficManagerEndpoint_updateWeight (167.46s)
=== RUN   TestAccAzureRMTrafficManagerEndpoint_updatePriority
--- PASS: TestAccAzureRMTrafficManagerEndpoint_updatePriority (122.34s)
=== RUN   TestAccAzureRMTrafficManagerEndpoint_nestedEndpoints
--- PASS: TestAccAzureRMTrafficManagerEndpoint_nestedEndpoints (98.02s)
=== RUN   TestAccAzureRMTrafficManagerProfile_weighted
--- PASS: TestAccAzureRMTrafficManagerProfile_weighted (75.61s)
=== RUN   TestAccAzureRMTrafficManagerProfile_performance
--- PASS: TestAccAzureRMTrafficManagerProfile_performance (88.42s)
=== RUN   TestAccAzureRMTrafficManagerProfile_priority
--- PASS: TestAccAzureRMTrafficManagerProfile_priority (93.49s)
=== RUN   TestAccAzureRMTrafficManagerProfile_withTags
--- PASS: TestAccAzureRMTrafficManagerProfile_withTags (114.20s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    1079.803s

pmcatominey · 2016-07-30T00:22:56Z

Cheers

On Sat, 30 Jul 2016, 01:22 Paul Stack, [email protected] wrote:

Hi @pmcatominey https://github.com/pmcatominey

This LGTM now :) I am going to hold off merging this until we finish
cutting RC4 though - so bare with me for a day or 2

% make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMTrafficManager'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMTrafficManager -timeout 120m
=== RUN TestAccAzureRMTrafficManagerEndpoint_basic
--- PASS: TestAccAzureRMTrafficManagerEndpoint_basic (137.88s)
=== RUN TestAccAzureRMTrafficManagerEndpoint_basicDisableExternal
--- PASS: TestAccAzureRMTrafficManagerEndpoint_basicDisableExternal (182.37s)
=== RUN TestAccAzureRMTrafficManagerEndpoint_updateWeight
--- PASS: TestAccAzureRMTrafficManagerEndpoint_updateWeight (167.46s)
=== RUN TestAccAzureRMTrafficManagerEndpoint_updatePriority
--- PASS: TestAccAzureRMTrafficManagerEndpoint_updatePriority (122.34s)
=== RUN TestAccAzureRMTrafficManagerEndpoint_nestedEndpoints
--- PASS: TestAccAzureRMTrafficManagerEndpoint_nestedEndpoints (98.02s)
=== RUN TestAccAzureRMTrafficManagerProfile_weighted
--- PASS: TestAccAzureRMTrafficManagerProfile_weighted (75.61s)
=== RUN TestAccAzureRMTrafficManagerProfile_performance
--- PASS: TestAccAzureRMTrafficManagerProfile_performance (88.42s)
=== RUN TestAccAzureRMTrafficManagerProfile_priority
--- PASS: TestAccAzureRMTrafficManagerProfile_priority (93.49s)
=== RUN TestAccAzureRMTrafficManagerProfile_withTags
--- PASS: TestAccAzureRMTrafficManagerProfile_withTags (114.20s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/azurerm 1079.803s

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7826 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4FSHlCYsL1FVI_YtC3EHuhJUl2U1Qpks5qapkxgaJpZM4JWEti
.

ghost · 2020-04-23T02:35:56Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Peter McAtominey added 4 commits July 20, 2016 23:58

provider/azurerm: vendor arm/trafficmanager package

bdd4b18

provider/azurerm: add azurerm_traffic_manager_profile resource

804ae2b

provider/azurerm: add azurerm_traffic_manager_endpoint resource

90fb4b6

provider/azurerm: document traffic manager resources

5710595

stack72 added enhancement provider/azurerm new-resource labels Jul 27, 2016

stack72 self-assigned this Jul 27, 2016

stack72 reviewed Jul 27, 2016
View reviewed changes

Peter McAtominey added 2 commits July 27, 2016 13:49

stack72 merged commit cc18e4d into hashicorp:master Jul 31, 2016

ghost locked and limited conversation to collaborators Apr 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provider/azurerm: add traffic manager resources #7826

provider/azurerm: add traffic manager resources #7826

pmcatominey commented Jul 27, 2016

stack72 commented Jul 27, 2016

stack72 Jul 27, 2016

pmcatominey commented Jul 29, 2016

stack72 commented Jul 30, 2016

pmcatominey commented Jul 30, 2016

ghost commented Apr 23, 2020

provider/azurerm: add traffic manager resources #7826

provider/azurerm: add traffic manager resources #7826

Conversation

pmcatominey commented Jul 27, 2016

stack72 commented Jul 27, 2016

stack72 Jul 27, 2016

Choose a reason for hiding this comment

pmcatominey commented Jul 29, 2016

stack72 commented Jul 30, 2016

pmcatominey commented Jul 30, 2016

ghost commented Apr 23, 2020