Adds consul_prepared_query resource #7474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanuber
force-pushed
the
f-consul-pq
branch
2 times, most recently
from
d402bbc to
2841ded
Compare
|
Hey @ryanuber! First look here is good, but there are a few build errors of the form: Do we need to also upgrade the vendored version of the Consul API? |
|
@jen20 yep! I was waiting for hashicorp/consul#2160 to get merged first. Vendor is updated and builds should pass now. I also fixed a few edge cases in my last couple of commits. |
| ttl = "5m" | ||
| } | ||
|
|
||
| template { |
There was a problem hiding this comment.
Since the service argument uses this regex, I'd put the template definition higher up.
There was a problem hiding this comment.
That's a good call. Probably easier to follow that way.
|
@ryanuber super excited to see this! |
|
This LGTM! Had to rebase it to remove the merge conflicts :) |
kwilczynski
pushed a commit
to kwilczynski/terraform
that referenced
this pull request
Aug 18, 2016
* provider/consul: first stab at adding prepared query support * provider/consul: flatten pq resource * provider/consul: implement updates for PQ's * provider/consul: implement PQ delete * provider/consul: add acceptance tests for prepared queries * provider/consul: add template support to PQ's * provider/consul: use substructures to express optional related components for PQs * website: first pass at consul prepared query docs * provider/consul: PQ's support datacenter option and store_token option * provider/consul: remove store_token on PQ's for now * provider/consul: allow specifying a separate stored_token * website: update consul PQ docs * website: add link to consul_prepared_query resource * vendor: update github.com/hashicorp/consul/api * provider/consul: handle 404's when reading prepared queries * provider/consul: prepared query failover dcs is a list * website: update consul PQ example usage * website: re-order arguments for consul prepared queries
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires hashicorp/consul#2160.
/cc @slackpad for prepared query stuff