Support greater than twenty db parameters

[ParthaDutta]

Test to deal with creating and updating greater than 20 database parameters in AWS

Thanks to Christopher Tiwald for his work https://github.com/hashicorp/terraform/pull/3082

Christopher can be found here https://github.com/ctiwald

[ParthaDutta]

Issues with certain key value database parameters

Cannot create a passing test for database parameters innodb_file_per_table and binlog_format
Seems that these database parameter(s) are created successfully
But testing it is failing; what being returned is different to expected values
Remove testing these parameters does not improve the situation; fails later on in the test run
For now the test is ignoring these parameters

Have limited understanding of how the test framework works, so am struggling to debug
Really appreciate another pair of eyes looking into this

The database key/value pairs are listed below

"binlog_format" : value = "MIXED"
"innodb_file_per_table" : value = 1

[tomelliff]

@stack72 is there anything needed to be done on this to get this advanced at all? Would be good to get this in at some point as we've got a pretty awkward workaround to get more than 20 parameters changed.

[stack72]

Hi @ParthaDutta

Thanks so much here for continuing the awesome work that @ctiwald started! Just ran the tests and all looks good :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBParameterGroup_'                        1 ↵
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBParameterGroup_ -timeout 120m
=== RUN   TestAccAWSDBParameterGroup_importBasic
--- PASS: TestAccAWSDBParameterGroup_importBasic (31.87s)
=== RUN   TestAccAWSDBParameterGroup_limit
--- PASS: TestAccAWSDBParameterGroup_limit (55.99s)
=== RUN   TestAccAWSDBParameterGroup_basic
--- PASS: TestAccAWSDBParameterGroup_basic (53.71s)
=== RUN   TestAccAWSDBParameterGroup_Only
--- PASS: TestAccAWSDBParameterGroup_Only (26.97s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    168.552s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.