-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Add support for Skipping Final Snapshot in RDS Cluster #6795
Conversation
ea79402
to
333984f
Compare
This isn't quite right. I ran
Re:
We do skip final snapshots now. From the docs:
When no |
finalSnapshot := d.Get("final_snapshot_identifier").(string) | ||
if finalSnapshot == "" { | ||
if skipFinalSnapshot == true { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making skip_final_snapshot
optional and default false indicates they do not want to skip it, and then assumes they'll supply a final_snapshot_identifier
, except that attribute is optional as well.
333984f
to
fe0d169
Compare
This works exactly the same as in DB Instance. We cannot use an empty string to skip the final snapshot or we get the following error: ``` only alphanumeric characters and hyphens allowed in "final_snapshot_identifier" ``` Therefore, we need to wrap this with another parameter. The we skip final snapshots by default as we do this currently and this would change the user functionality
fe0d169
to
5a3a061
Compare
@catsby you are indeed correct. This should take care of it now - i was just able to replicate everything you saw and it's now fixed |
When you
|
Better, thanks! |
…ashicorp#6795) * provider/aws: Add support for Skipping Final Snapshot in RDS Cluster
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes #6786
This works exactly the same as in DB Instance. We cannot use an empty
string to skip the final snapshot or we get the following error:
Therefore, we need to wrap this with another parameter. The we DO NOT
skip final snapshots by default as we currently create them right now
and this would change the user functionality