providers/cloudflare: record can manage apex records #6449
Conversation
|
LGTM, think we may have a test account record conflict with our nightly acceptance tests to sort out though |
|
In the course of testing this, @clint found a huge issue with the provider. Due to the way it looks up records, it is capable of finding (and deleting!) incorrect records. This is caused by the fact that it looks up records by name, rather than by unique ID that Cloudflare returns. Upon further investigation, the library that we use and the official Cloudflare Go library don't support getting that ID. I've forked and made a PR to the official Cloudflare repo to do this. This PR is now updated to use a new lib (my fork of the official Cloudflare Go lib) so that we properly use record IDs. This cleans up the code a lot. All prior tests pass:
|
Apex records must be created by specifying "@" as the name, but this caused Refresh and Delete errors.
The most improtant change is using record IDs as identifiers.
mitchellh
force-pushed
the
b-cloudflare-apex
branch
from
ff971fa to
109b3f5
Compare
|
Checks out 👍 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Apex records must be created by specifying "@" as the name, but this caused Refresh and Delete errors since after create the "@" is stripped from the API results. This modifies the resource to automatically strip this when looking for the record.
Test included.