VMWare vCloud Director Support

[devopsbrett]

In regards to issue #3784 this PR addresses support for vCloud Director with supporting tests and documentation

[phinze]

If there's no implementation for Update it's better to just omit this function from the Resource definition. That will also trigger a check to ensure that all the fields are set to ForceNew, which they should be when an Update is not available.

[phinze]

Wow, this is looking really great! Tests and docs and everything. 👍

I just completed a review with a bunch of inline comments. Let me know if you have any follow up questions on those.

Great work so far! After we address the comments this should be good to go. 🚀

[nickithewatt]

@phinze Do you need us to version the dependent github.com/hmrc/vmware-govcd library? I am not sure how these versions get into appropriate terraform/deps/v0-6-X.json files, I presume this automatically pulls in appropriate version info and code and vendors them at release time?

[phinze]

@nickithewatt Yep - no need to explicitly pin the dependency. Our policy is to track master between releases and snapshot at release time, so we'll capture reproducible build information with each release.

[devopsbrett]

Hi Paul,

Thank you for the comments, they were a great help. I believe these have all been addressed now but let me know if you think there's anything else I should change.

[devopsbrett]

@phinze Sorry, added one final change. That should be everything now though.

[phinze]

Looking good! Let's land this sucker. 🍭

[pasikarkkainen]

Terraform vcd provider seems to work fine for me in my inital tests.. Thanks a lot!

There's one issue/limitation I noticed though.. I'd like to be able to specify different "original port" and "translated port" for DNAT rules.. currently it's only possible to specify "port", so both the "original port" and "translated port" will be the same, which isn't optimal.

So basicly I'd like to support for example multiple port forwards to multiple ssh jump boxes, like this;
port 2001 --> IP1 port 22
port 2002 --> IP2 port 22
port 2003 --> IP3 port 22

and so on. I guess I should check the sources to see if it's easy to modify and add support for that..

[pasikarkkainen]

Ok, so in vmware-govcd edgegateway.go func AddNATMapping(nattype, externalIP, internalIP, port string) I can see this:

    //add rule
    natRule := &types.NatRule{
            RuleType:  nattype,
            IsEnabled: true,
            GatewayNatRule: &types.GatewayNatRule{
                    Interface: &types.Reference{
                            HREF: uplink.HREF,
                    },
                    OriginalIP:     externalIP,
                    OriginalPort:   port,
                    TranslatedIP:   internalIP,
                    TranslatedPort: port,
                    Protocol:       "tcp",
            },
    }

so "port" is used for both OriginalPort and TranslatedPort.. so the limitation seems to come from that level.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.