Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NetRC support to the provider installer #35843

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

aaklilu
Copy link
Contributor

@aaklilu aaklilu commented Oct 11, 2024

An interim solution to lack of credential while downloading provider archives.

Fixes #29349

Target Release

1.10.x

Draft CHANGELOG entry

ENHANCEMENTS

  • Provider installation now support NetRC and utilises the credentials configured in .netrc file. Similar to module downloads.

@crw
Copy link
Contributor

crw commented Oct 11, 2024

Thanks for this submission!

@aaklilu aaklilu force-pushed the main branch 2 times, most recently from 00c0cea to 869c93c Compare October 14, 2024 12:16
@crw
Copy link
Contributor

crw commented Oct 15, 2024

Hi @aaklilu, we discussed this in triage today. Generally speaking there is agreement that this is probably the correct approach. The main blocker to doing a full review is maintainer availability. My best guess is that we'll check back in on this PR mid-November to consider a review. I just wanted to set expectations up-front as to timelines. Thanks again for this submission.

@aaklilu
Copy link
Contributor Author

aaklilu commented Oct 15, 2024

Hi @aaklilu, we discussed this in triage today. Generally speaking there is agreement that this is probably the correct approach. The main blocker to doing a full review is maintainer availability. My best guess is that we'll check back in on this PR mid-November to consider a review. I just wanted to set expectations up-front as to timelines. Thanks again for this submission.

Thank you @crw for the update.

@crw
Copy link
Contributor

crw commented Nov 11, 2024

Hi @aaklilu, I have been off for the past three weeks so apologies for this late update. As this change would not make a difference for the Hashicorp Terraform Registry (public or private via Enterprise), this change is unlikely to be prioritized in the near future. If you think this is incorrect, especially if you think the Hashicorp enterprise registry could benefit from this change, please let me know as that could change the decision-making process. Thanks very much!

@aaklilu
Copy link
Contributor Author

aaklilu commented Nov 12, 2024

Hi @aaklilu, I have been off for the past three weeks so apologies for this late update. As this change would not make a difference for the Hashicorp Terraform Registry (public or private via Enterprise), this change is unlikely to be prioritized in the near future. If you think this is incorrect, especially if you think the Hashicorp enterprise registry could benefit from this change, please let me know as that could change the decision-making process. Thanks very much!

It's fine, thanks for the update @crw

@liamcervante
Copy link
Member

Hi @aaklilu, I'm happy to review and merge this. The change actually looks fine to me, but before I merge it could you take a look at #36022 and let me know if the documentation update there is actually understandable for someone using this externally? Thanks!

@liamcervante liamcervante self-assigned this Nov 19, 2024
@crw crw added the waiting-response An issue/pull request is waiting for a response from the community label Nov 19, 2024
@aaklilu
Copy link
Contributor Author

aaklilu commented Nov 19, 2024

Hi @aaklilu, I'm happy to review and merge this. The change actually looks fine to me, but before I merge it could you take a look at #36022 and let me know if the documentation update there is actually understandable for someone using this externally? Thanks!

Hey @liamcervante its quite clear. Thanks!

@liamcervante
Copy link
Member

I'm just waiting for one of our tech writers to okay my docs change in #36022, and then we can merge both together.

@liamcervante liamcervante merged commit ccdd825 into hashicorp:main Nov 21, 2024
7 checks passed
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
3 participants