-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resolution message for S3/DynamoDB state checksum mismatch #34387
Conversation
@jbardin Could someone please review this? |
Apologies, somehow I missed this (GitHub notifications seem to be a little flaky). I've notified the AWS provider team. |
@crw Thanks. Is there any update yet, I can't see any reviewers assigned to the PR? |
It has not been picked up yet for review. I can see this on their project board, so it is basically backlogged at the moment. I'll check in with them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% TF_ACC=1 go test ./...
ok github.com/hashicorp/terraform/internal/backend/remote-state/s3 146.752s
Thanks for your contribution, @mschfh! 👍 |
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
The current resolution message incorrectly suggests updating the DynamoDB value to the value already stored there, rather than to the calculated checksum of the S3 state file.
Draft CHANGELOG entry
BUG FIXES