Convert int to int64 when building the cluster.NodeConfig struct

[djworth]

related to issue #2901

[apparentlymart]

👍 looks plausible to me. There's a similar thing going on in the AWS EBS code where the disk sizes are set.

I eagerly await the day when someone wants to create a 4.3 exabyte disk and Terraform fails to represent it correctly due to its use of a paltry 32-bit integer. 😀

[radeksimko]

@djworth Thanks for noticing and sending the PR! Would you mind attaching a test or modify an existing test, so it's covering this bug?

@apparentlymart I didn't know about EBS, but I know there's the same bug in google_compute_instance_template, which the linked issue is actually mentioning.

[djworth]

@radeksimko Sure thing!

[sparkprime]

I fixed the other one, I'll leave this one to you lot :)

[radeksimko]

@apparentlymart Can you explain further what the problem is with EBS volumes? I just checked that resource and all int64 attributes seem to be ok - in fact since that EBS support has been implemented, it was correct:

terraform/builtin/providers/aws/resource_aws_ebs_volume.go

Lines 73 to 81 in dcebff7

	if value, ok := d.GetOk("iops"); ok {
	request.IOPS = aws.Long(int64(value.(int)))
	}
	if value, ok := d.GetOk("kms_key_id"); ok {
	request.KMSKeyID = aws.String(value.(string))
	}
	if value, ok := d.GetOk("size"); ok {
	request.Size = aws.Long(int64(value.(int)))
	}

[apparentlymart]

@radeksimko sorry I wasn't meaning to say that there is an issue there now, but more that the issue had existed historically and we did the same workaround. So my comment was more "this seems like a reasonable solution because it's how we already solved EBS volumes", not "this also needs to be done for EBS volumes". I apologize for not being clearer.

[radeksimko]

Merging, I will add the test in a separate commit.
Thanks again @djworth

[radeksimko]

Done in 53499a9

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.