Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show resource name in taint -allow-missing warning #27501

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Jan 13, 2021

Show the resource name in the warning when allow-missing is used and no resource matches.

Show the resource name in the warning when allow-missing
is used and no resource matches
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #27501 (67853d8) into master (61f9d21) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
command/taint.go 38.23% <100.00%> (ø)
states/statefile/version4.go 58.19% <0.00%> (+0.23%) ⬆️
dag/marshal.go 63.49% <0.00%> (+1.58%) ⬆️
terraform/node_resource_plan.go 98.05% <0.00%> (+1.94%) ⬆️

@pselle pselle requested a review from a team January 13, 2021 20:05
@pselle pselle merged commit 1e10051 into master Jan 14, 2021
@pselle pselle deleted the pselle/taint-err branch January 14, 2021 15:02
@ghost
Copy link

ghost commented Feb 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants