Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS autoscaling group names should be able to be autogenerated #2632

Closed
jszwedko opened this issue Jul 6, 2015 · 8 comments · Fixed by #3710
Closed

AWS autoscaling group names should be able to be autogenerated #2632

jszwedko opened this issue Jul 6, 2015 · 8 comments · Fixed by #3710

Comments

@jszwedko
Copy link
Contributor

jszwedko commented Jul 6, 2015

Currently name is required and must be unique within the region/account.

@ericfode
Copy link

ericfode commented Jul 6, 2015

👍

@radeksimko
Copy link
Member

I'm 👍 on this, but I would wait with implementation until #2571 gets reviewed & merged, so we have the prefixed-unique-ID functionality in core and we can use it here too.

@jszwedko
Copy link
Contributor Author

jszwedko commented Jul 7, 2015

@radeksimko 👍 👍

@stack72
Copy link
Contributor

stack72 commented Oct 30, 2015

@radeksimko #2571 is now merged so I think this one can be closed now - is this correct? //cc @phinze

@radeksimko
Copy link
Member

@stack72 The function for generating unique names is merged, but ASGs still have name Required: true:
https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/resource_aws_autoscaling_group.go#L28

@stack72
Copy link
Contributor

stack72 commented Oct 31, 2015

ok, I opened the PR that allows this to work now :) Thanks for the hints @radeksimko

@catsby
Copy link
Contributor

catsby commented Nov 2, 2015

I merged #3710 , completing this. Thanks all!

@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants