Generalize target addresses before expansion #25760
Conversation
Codecov Report
|
| case addrs.AbsResourceInstance: | ||
| targetAddr = instance.ContainingResource().Config() | ||
| case addrs.ModuleInstance: | ||
| targetAddr = instance.Module() |
There was a problem hiding this comment.
I was curious about why the module case was removed here, and tried to check if targeting a module instance would work. It doesn't seem to (unless my test is broken), and I couldn't find a way to make it work, but I'm very unfamiliar with this code so that's not surprising.
Should terraform apply -target=module.mod[1] work? Does it already and I'm just mistaken?
There was a problem hiding this comment.
Thanks @alisdair! It appears I was thinking about this block in terms of only resource addresses (probably because of the case statement), and not the module itself. Let me add some tests in here too, since that was obviously not covered.
Before expansion happens, we only have expansion resource nodes that know their ConfigResource address. In order to properly compare these to targets within a module instance, we need to generalize the target to also be a ConfigResource. We can also remove the IgnoreIndices field from the transformer, since we have addresses that are properly scoped and can compare them in the correct context.
When working with a ConfigResource, the generalization of a ModuleInstance to a Module was inadvertently dropped, and there was to test coverage for that type of target. Ensure we can target a specific module instance alone.
jbardin
force-pushed
the
jbardin/target-resource
branch
from
cc766aa to
b9e076e
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Before expansion happens, we only have expansion resource nodes that
know their ConfigResource address. In order to properly compare these to
targets within a module instance, we need to generalize the target to
also be a ConfigResource.
We can also remove the IgnoreIndices field from the transformer, since
we have addresses that are properly scoped and can compare them in the
correct context.
Fixes #25748