Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configs: Custom variable validation is no longer experimental #25054

Merged
merged 1 commit into from
May 28, 2020

Conversation

apparentlymart
Copy link
Contributor

All of the feedback from the experiment described enhancements that can potentially be added later without breaking changes, so this change simply removes the experiment gate from the feature as originally implemented with no changes to its functionality.

Further enhancements may follow in later releases, but the goal of this change is just to ship the feature exactly as it was under the experiment.

Most of the changes here are cleaning up the experiment opt-ins from our test cases. The most important parts are in configs/experiments.go and in experiments/experiment.go.

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #25054 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
configs/experiments.go 77.27% <ø> (-2.73%) ⬇️
terraform/node_resource_plan.go 91.80% <0.00%> (-1.64%) ⬇️
backend/remote/backend_common.go 54.57% <0.00%> (-0.68%) ⬇️
states/statefile/version4.go 56.16% <0.00%> (-0.29%) ⬇️
terraform/evaluate.go 53.60% <0.00%> (+0.45%) ⬆️

All of the feedback from the experiment described enhancements that can
potentially be added later without breaking changes, so this change simply
removes the experiment gate from the feature as originally implemented
with no changes to its functionality.

Further enhancements may follow in later releases, but the goal of this
change is just to ship the feature exactly as it was under the experiment.

Most of the changes here are cleaning up the experiment opt-ins from our
test cases. The most important parts are in configs/experiments.go and in
experiments/experiment.go .
@apparentlymart apparentlymart force-pushed the f-custom-validation-nonexperiment branch from 52803b9 to ce99694 Compare May 27, 2020 21:42
@apparentlymart apparentlymart requested a review from a team May 27, 2020 21:44
@apparentlymart apparentlymart marked this pull request as ready for review May 28, 2020 23:06
@apparentlymart apparentlymart merged commit d1bc412 into master May 28, 2020
@apparentlymart apparentlymart deleted the f-custom-validation-nonexperiment branch May 28, 2020 23:08
@danieldreier danieldreier added this to the v0.13.0 milestone May 29, 2020
@plaformsre
Copy link

I heard about this a bit late and would like to thank you for this enhancement on input validation of variables.

We do a lot of manipulation with locals and mesh together variables, data and other source of values.

Would it be possible to extend the validation block also for locals?

It would add a lot of value for enforcing rules in one place for us.

Many thanks,
Dejan

@ghost
Copy link

ghost commented Jun 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants