Unable to enforce (single) quote around yml string value

[t638403]

Download Terraform

sudo mkdir /opt/terraform
cd /opt/terraform
sudo wget https://releases.hashicorp.com/terraform/0.12.9/terraform_0.12.9_linux_amd64.zip
sudo unzip terraform_0.12.9_linux_amd64.zip
echo "export PATH=\$PATH:/opt/terraform" >> ~/.zshrc

Current Terraform Version

Terraform v0.12.9
+ provider.helm v0.10.2
+ provider.kubernetes v1.9.0

Use-cases

I have this terraform resource for elasticsearch on kubernetes.

resource "helm_release" "elasticsearch" {
    name      = "some name"
    chart     = "elastic/elasticsearch"
    set {
        name = "roles.master"
        value = "true"
    }
...
}

The values.yaml for helm renders this as

...
roles:
   master: true
...

Unfortunately helm is unable to render this into the statefulset.yaml template.

Error: rpc error: code = Unknown desc = render error in "elasticsearch/templates/statefulset.yaml": template: elasticsearch/templates/statefulset.yaml:188:17: executing "elasticsearch/templates/statefulset.yaml" at <eq .Values.roles.mas...>: error calling eq: incompatible types for comparison

I have tested directly with helm and when I wrap the true value in single quotes (master: 'true') helm becomes able to render it into the statefulset.yaml template. However I can not find a way to enforce this using terraform set.

Attempted Solutions

I have tried:

1:

set {
        name = "roles.master"
        value = "true"
    }

which results in master: true.

2:

set {
        name = "roles.master"
        value = "${true}"
    }

which results in master: true

3:

set {
        name = "roles.master"
        value = "'${true}'"
    }

which results in master: '''true'''

4:

set {
        name = "roles.master"
        value = <<EOF
true
EOF
    }

which results in

master: |
    true

5:

set {
        name = "roles.master"
        value = "\\\\'${var.es_node_roleMaster}\\\\'"
    }

which results in master: \'true\'

Proposal

Some function quote(string) which will enforce a single quote around the string.

References

The helm template:
https://github.com/elastic/helm-charts/blob/master/elasticsearch/templates/statefulset.yaml

[teamterraform]

Hi @t638403!

We've asked the bot to consider this a Helm provider bug because the Helm provider seems to be trying to present an abstraction over the YAML but that abstraction is leaking here due to the lack of quoting. Having the Helm provider handle this quoting automatically would then provide the abstraction as intended, avoiding the need for the user to worry about how this value will ultimately be encoded in YAML.

Our bot will close this issue and open a new issue with the same content on your behalf in the Helm provider repository.

[teamterraform]

(With that said, Terraform already has a function jsonencode which can produce a JSON-quoted version of a string value. Since YAML is a superset of JSON, jsonencode should be a sufficient workaround for the moment, with the caveat that if this bug is later fixed upstream you'll probably end up with a double-quoted value.)

[ghost]

This issue has been automatically migrated to hashicorp/terraform-provider-helm#341 because it looks like an issue with that provider. If you believe this is not an issue with the provider, please reply to hashicorp/terraform-provider-helm#341.

[davidschrooten]

try https://www.terraform.io/docs/configuration/functions/format.html

e.g. in terraform console:

> format("'%v'", true)
'true'

[t638403]

@teamterraform and @davidq2q thanks for the response!

Finally I was able to use set_string in stead of set:

set_string {
        name = "roles.master"
        value = true   
}

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.