Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add friendly error for when registry unresponsive #20853

Merged
merged 2 commits into from
Mar 28, 2019

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Mar 27, 2019

If the registry is unresponsive, you will now get an error specific to this, rather than a misleading "provider unavailable" type error. Also adds debug logging for when errors like this may occur.

If the registry is unresponsive, you will now get an error
specific to this, rather than a misleading "provider unavailable" type
error. Also adds debug logging for when errors like this may occur
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 27, 2019

CLA assistant check
All committers have signed the CLA.

@pselle pselle requested a review from a team March 27, 2019 20:31
Copy link
Contributor

@apparentlymart apparentlymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I left a thought inline, but it's just an enhancement and so there's no reason to hold on merging this to get it done, if indeed we decide we want to do it.

command/init.go Show resolved Hide resolved
@pselle pselle merged commit d1c1bc6 into hashicorp:master Mar 28, 2019
@pselle pselle deleted the err-handling-registry-unresponsive branch March 28, 2019 17:09
@ghost
Copy link

ghost commented Aug 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants