Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail decoding null values from plan changes #19726

Merged
merged 3 commits into from
Dec 20, 2018
Merged

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Dec 20, 2018

An empty change value cannot be decoded, so return a cty.NullVal to indicate the absence of a state value in this case.

Fixes #19149

An empty DynamicValue can't be decoded but indicates no state, so just
return a NullVal.
@jbardin jbardin requested a review from a team December 20, 2018 18:13
@jbardin jbardin force-pushed the jbardin/destroy-plan branch 3 times, most recently from 5ee0a88 to c053174 Compare December 20, 2018 19:57
@jbardin jbardin force-pushed the jbardin/destroy-plan branch from c053174 to f3fe618 Compare December 20, 2018 20:11
@jbardin jbardin merged commit 5ff0035 into master Dec 20, 2018
@jbardin jbardin deleted the jbardin/destroy-plan branch December 20, 2018 20:35
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic when applying a saved plan file created with "terraform plan -destroy -out=tfplan"
1 participant