command/format: Render null in dark gray

[radeksimko]

I thought it would be even nicer to render the whole line as red, but then the whole -> null part becomes kinda redundant and I assume we want to keep it there for non-colorized outputs as minus signs alone might not be immediately obvious.

Before

After

[apparentlymart]

Seems reasonable!

I like it not all being red, since I want to avoid any actual information being colorized to ensure that it'll remain readable on terminals with weirdly-configured color settings. Since the -> null part is more of an "icon" than actual information it's not so much of a big deal if it's hard to actually read the text.

[apparentlymart]

Oh, one thing we should check here:

If a resource is being updated to set something that was previously set to null, and that thing requires replacement, does the # requires replacement annotation still stand out obviously or does it get visually drowned out by the red -> null noise?

That annotation being rendered in bold might be enough to avoid that, but if not then I think it's better to leave it uncolored so that we can reserve red text for more significant situations.

[apparentlymart]

Looking at this again with fresh eyes, I think that this makes the nulls a little too prominent in the output here, which risks distracting from other information we want to keep prominent, like whether something is going to be replaced.

Since the -> null annotations are already redundant with the - markers at the start, I wonder if instead we should make them [dark_gray] to de-emphasize them. I added these extra -> null markers in there because I got initial feedback that the minus signs alone were confusing, but they also add a lot of visual noise to the diff. Hopefully de-emphasizing them will make it easier to visually skim and see the old values, which are the main interesting thing to see so you can understand exactly what is being deleted.

(I'd include the -> in the de-emphasizing too.)

[radeksimko]

@apparentlymart Thanks for the feedback. Dark gray does look better in this context. See updated screenshot above.

Are you happy for me to merge this?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.