Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/schema: Fix timeout parsing during Provider.Diff #19286

Merged
merged 4 commits into from
Nov 6, 2018

Conversation

radeksimko
Copy link
Member

I'm not sure when/where/why we decided to produce a simple map instead of slice (read as I didn't go through all the refactoring commits), but it makes more sense to me, so I'm assuming it was intentional.

Also I don't know why are we were not originally erroring out on invalid timeout types as I couldn't find a corresponding PR to this commit aa3677c
cc @catsby ^

@jbardin
Copy link
Member

jbardin commented Nov 5, 2018

Thanks @radeksimko,

This makes sense, since blocks were always decoded in hcl as []map[string]interface{}, and in special cases they were hoisted up into a single map[string]interface{}. Since timeouts were never in the actual schema for some reason, that differentiation couldn't be done when the config was loading.

Now that they are present in the config as a NestingSingle block, they will be converted correctly by the shims before making it to the ConfigDecode function.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants