helper/schema: Fix timeout parsing during Provider.Diff #19286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure when/where/why we decided to produce a simple map instead of slice (read as I didn't go through all the refactoring commits), but it makes more sense to me, so I'm assuming it was intentional.
Also I don't know why are we were not originally erroring out on invalid timeout types as I couldn't find a corresponding PR to this commit aa3677c
cc @catsby ^