Feature/updated ssh cert auth retargeted to master #18896
Conversation
sherodtaylor
force-pushed
the
feature/updated-ssh-cert-auth-v0.12-dev
branch
from
e6c885a to
6c46c9d
Compare
|
@jbardin @apparentlymart I'm back! I reopened this PR and rebased 0.12-dev |
|
and updated based on the old commits |
|
@apparentlymart i'll retarget this to master. Most of the newer work is on here. I left my last job at paxos. |
sherodtaylor
force-pushed
the
feature/updated-ssh-cert-auth-v0.12-dev
branch
2 times, most recently
from
885ada5 to
8292668
Compare
sherodtaylor
changed the title
|
@jbardin @apparentlymart anybody able to look at this? I've updated it for master and also addressed the comments. :) |
sherodtaylor
force-pushed
the
feature/updated-ssh-cert-auth-v0.12-dev
branch
from
8292668 to
b680e33
Compare
|
@mildwonkey @apparentlymart anybody :) can i get a look at this? |
|
Hi @sherodtaylor, Sorry about the delay here. I do intend to review this soon. Once we get master into a stable state, then I'll be going through the backlog of pending PRs. |
|
@jbardin hi thanks for the response i was wondering how long until this would take? |
| @@ -77,6 +77,11 @@ provisioner "file" { | |||
| [the `file` function](/docs/configuration/functions/file.html). This takes | |||
| preference over the password if provided. | |||
|
|
|||
| * `certificate` - The contents of an signed CA Certificate. The certificate argument must be | |||
| * `certificate` - The contents of an signed CA Certificate. The certificate argument must be | ||
| used in conjunction with a `private_key`. These can | ||
| be loaded from a file on disk using the [`file()` interpolation | ||
| function](/docs/configuration/interpolation.html#file_path_). |
There was a problem hiding this comment.
Use the same markdown link from above, and remove the newline in the link
sherodtaylor
force-pushed
the
feature/updated-ssh-cert-auth-v0.12-dev
branch
from
b680e33 to
c456d96
Compare
|
|
|
@jbardin hey I updated the pr |
|
Thanks @sherodtaylor! |
|
@jbardin np :) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This pull request addresses #14413. It adds certificate support for the ssh provisioner. It adds a new parameter certificate which is used to authenticate ssh sessions. I updated the provisioner_test and docs to reflect this. #18017. Also updated the communicator test to validate ssh certificates. Since this was blocked by dev I decided up create this pr for dev. Reopened this as it was closed #18421