'redirect_all_requests_to' stripping query string

[FireBall1725]

When creating an S3 bucket to do a site redirect I am running into an issue where the redirect_all_requests_to option will strip out any querystrings.

for example:

redirect_all_requests_to = "https://www.foo.com?bar=test"

will save the following on S3

Hostname: www.foo.com
Protocol: https

The following shows up in the debug logs

module.website.aws_s3_bucket.website_bucket: Modifying... (ID: www.domain.com)
  website.0.redirect_all_requests_to: "https://login.domain.com/idp/startSSO.ping" => "https://login.domain.com/idp/startSSO.ping?PartnerSpId=https%3A%2F%2Fapp.service.com"
2017-10-25T13:33:29.525-0700 [DEBUG] plugin.terraform-provider-aws_v1.1.0_x4: 2017/10/25 13:33:29 [DEBUG] S3 put bucket website: {
2017-10-25T13:33:29.525-0700 [DEBUG] plugin.terraform-provider-aws_v1.1.0_x4:   Bucket: "www.domain.com",
2017-10-25T13:33:29.525-0700 [DEBUG] plugin.terraform-provider-aws_v1.1.0_x4:   WebsiteConfiguration: {
2017-10-25T13:33:29.525-0700 [DEBUG] plugin.terraform-provider-aws_v1.1.0_x4:     RedirectAllRequestsTo: {
2017-10-25T13:33:29.525-0700 [DEBUG] plugin.terraform-provider-aws_v1.1.0_x4:       HostName: "login.domain.com/idp/startSSO.ping",
2017-10-25T13:33:29.525-0700 [DEBUG] plugin.terraform-provider-aws_v1.1.0_x4:       Protocol: "https"
2017-10-25T13:33:29.525-0700 [DEBUG] plugin.terraform-provider-aws_v1.1.0_x4:     }
2017-10-25T13:33:29.525-0700 [DEBUG] plugin.terraform-provider-aws_v1.1.0_x4:   }
2017-10-25T13:33:29.525-0700 [DEBUG] plugin.terraform-provider-aws_v1.1.0_x4: }
2017-10-25T13:33:29.525-0700 [DEBUG] plugin.terraform-provider-aws_v1.1.0_x4: 2017/10/25 13:33:29 [DEBUG] Waiting for state to become: [success]

So you can see it detects that the url is incorrect, so it updates it to the correct url, but it doesn't actually save it, it strips everything after the query string.

(I changed the domain name in the example above to obfuscate what this is for)

I am running the latest version of Terraform

[FireBall1725]

I should mention that if i do it with the ruby api in a manual application, that it does work as expected.

http://docs.aws.amazon.com/sdkforruby/api/Aws/S3/Types/RedirectAllRequestsTo.html

Or if i go to the AWS console and manually update the url in there.

[FireBall1725]

Confirmed that PR#2059 does resolve my issue

[FireBall1725]

[hashibot]

This issue has been automatically migrated to hashicorp/terraform-provider-aws#2061 because it looks like an issue with that provider. If you believe this is not an issue with the provider, please reply to this issue and let us know.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.