Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RemoteClient.Delete for s3.Backend.DeleteState #15383

Merged
merged 2 commits into from
Jun 23, 2017

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Jun 23, 2017

The s3.Backend was using it's own code for DeleteState, but the dynamo
entries are only handled through the RemoteClient. Have DeleteState use
a RemoteClient for delete.

Fixes #15161

jbardin added 2 commits June 23, 2017 10:16
This ensures that we don't leave any conflicting state artifacts
preventing the recreation of a named state.
The s3.Backend was using it's own code for DeleteState, but the dynamo
entries are only handled through the RemoteClient. Have DeleteState use
a RemoteClient for delete.
@jbardin
Copy link
Member Author

jbardin commented Jun 23, 2017

$ TF_ACC=1 go test -v 2> /dev/null
=== RUN   TestBackend_impl
--- PASS: TestBackend_impl (0.00s)
=== RUN   TestBackendConfig
--- PASS: TestBackendConfig (1.20s)
=== RUN   TestBackend
--- PASS: TestBackend (5.48s)
	backend_test.go:248: creating S3 bucket terraform-remote-s3-test-594d255e in us-east-1
=== RUN   TestBackendLocked
--- PASS: TestBackendLocked (28.77s)
	backend_test.go:248: creating S3 bucket terraform-remote-s3-test-594d2564 in us-east-1
	testing.go:240: TestBackend: testing state locking for *s3.Backend
=== RUN   TestBackendExtraPaths
--- PASS: TestBackendExtraPaths (7.65s)
	backend_test.go:248: creating S3 bucket terraform-remote-s3-test-594d2580 in us-east-1
=== RUN   TestRemoteClient_impl
--- PASS: TestRemoteClient_impl (0.00s)
=== RUN   TestRemoteClient
--- PASS: TestRemoteClient (2.28s)
	backend_test.go:248: creating S3 bucket terraform-remote-s3-test-594d2588 in us-east-1
=== RUN   TestRemoteClientLocks
--- PASS: TestRemoteClientLocks (23.07s)
	backend_test.go:248: creating S3 bucket terraform-remote-s3-test-594d258a in us-east-1
=== RUN   TestForceUnlock
--- PASS: TestForceUnlock (16.92s)
	backend_test.go:248: creating S3 bucket terraform-remote-s3-test-force-594d25a1 in us-east-1
=== RUN   TestRemoteClient_clientMD5
--- PASS: TestRemoteClient_clientMD5 (13.62s)
	backend_test.go:248: creating S3 bucket terraform-remote-s3-test-594d25b2 in us-east-1
=== RUN   TestRemoteClient_stateChecksum
--- PASS: TestRemoteClient_stateChecksum (16.69s)
	backend_test.go:248: creating S3 bucket terraform-remote-s3-test-594d25c0 in us-east-1
PASS

@jbardin jbardin merged commit 9c874f3 into master Jun 23, 2017
@jbardin jbardin deleted the jbardin/s3-delete-state branch June 23, 2017 15:13
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform crash while creating new env with s3 backend
2 participants