Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Retry ECS svc update on ServiceNotFoundException #15073

Merged
merged 1 commit into from
Jun 5, 2017

Conversation

radeksimko
Copy link
Member

This is to address the following test failures:

=== RUN   TestAccAWSEcsServiceWithFamilyAndRevision
--- FAIL: TestAccAWSEcsServiceWithFamilyAndRevision (11.63s)
    testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_ecs_service.jenkins: 1 error(s) occurred:
        
        * aws_ecs_service.jenkins: ServiceNotFoundException: Service not found.
            status code: 400, request id: 7111c49f-49b4-11e7-8a31-1f4c10a1cce8
=== RUN   TestAccAWSEcsService_withAlb
--- FAIL: TestAccAWSEcsService_withAlb (187.15s)
    testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_ecs_service.with_alb: 1 error(s) occurred:
        
        * aws_ecs_service.with_alb: ServiceNotFoundException: Service not found.
            status code: 400, request id: e22e863d-49b4-11e7-9e01-79f4e5b714b9

Here's a relevant snippet from the debug log:

2017/06/05 06:04:49 [DEBUG] [aws-sdk-go] DEBUG: Response ecs/UpdateService Details:
---[ RESPONSE ]--------------------------------------
HTTP/1.1 400 Bad Request
Connection: close
Content-Length: 68
Content-Type: application/x-amz-json-1.1
Date: Mon, 05 Jun 2017 06:04:49 GMT
Server: Server
X-Amzn-Requestid: e22e863d-49b4-11e7-9e01-79f4e5b714b9


{"__type":"ServiceNotFoundException","message":"Service not found."}
-----------------------------------------------------

Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More eventual consistency issues?

Regardless, LGTM

@radeksimko radeksimko merged commit cf58139 into master Jun 5, 2017
@radeksimko radeksimko deleted the b-aws-ecs-not-found-retry branch June 5, 2017 12:20
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants