Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade github.com/cyberdelia/heroku-go package #14611

Closed
cmorent opened this issue May 18, 2017 · 1 comment · Fixed by #14672
Closed

Upgrade github.com/cyberdelia/heroku-go package #14611

cmorent opened this issue May 18, 2017 · 1 comment · Fixed by #14672

Comments

@cmorent
Copy link
Contributor

cmorent commented May 18, 2017

There is a new version revision for the github.com/cyberdelia/heroku-go package but, as mentioned in #14508, we can't simply fetch it with govendor as it breaks many things:

$ make test TEST=./builtin/providers/heroku
==> Checking that code complies with gofmt requirements...
==> Checking AWS provider for unchecked errors...
==> NOTE: at this time we only look for uncheck errors in the AWS package
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/17 17:12:15 Generated command/internal_plugin_list.go
go test -i ./builtin/providers/heroku || exit 1
echo ./builtin/providers/heroku | \
		xargs -t -n4 go test  -timeout=60s -parallel=4
go test -timeout=60s -parallel=4 ./builtin/providers/heroku
# github.com/cmorent/terraform/builtin/providers/heroku
builtin/providers/heroku/resource_heroku_addon.go:181: undefined: heroku.AddOnInfoResult
builtin/providers/heroku/resource_heroku_cert.go:125: undefined: heroku.SSLEndpointInfoResult
builtin/providers/heroku/resource_heroku_addon_test.go:94: undefined: heroku.AddOnInfoResult
builtin/providers/heroku/resource_heroku_addon_test.go:105: undefined: heroku.AddOnInfoResult
builtin/providers/heroku/resource_heroku_app_feature_test.go:65: undefined: heroku.AppFeatureInfoResult
builtin/providers/heroku/resource_heroku_app_feature_test.go:98: undefined: heroku.AppFeatureInfoResult
builtin/providers/heroku/resource_heroku_app_test.go:255: undefined: heroku.AppInfoResult
builtin/providers/heroku/resource_heroku_app_test.go:284: undefined: heroku.AppInfoResult
builtin/providers/heroku/resource_heroku_app_test.go:311: undefined: heroku.AppInfoResult
builtin/providers/heroku/resource_heroku_app_test.go:427: undefined: heroku.AppInfoResult
builtin/providers/heroku/resource_heroku_app_test.go:427: too many errors
FAIL	github.com/cmorent/terraform/builtin/providers/heroku [build failed]
make: *** [test] Error 1

This upgrade implies a lot of changes in the code of the heroku provider I think.

Terraform Version

Terraform 0.9.6-dev

Affected Resource(s)

  • heroku provider

Steps to Reproduce

  1. govendor fetch github.com/cyberdelia/heroku-go/v3
  2. make test TEST=./builtin/providers/heroku

References

@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants