provider/aws: aws_db_option_group normalizes name to lowercase

[thrashr888]

This fixes #11040. The code here lowercases the name and/or prefix before sending it to the AWS API and the terraform state. This means the state will match the actual resource name and be able to converge the diff.

Other providers might validate and throw an error or warning instead of just letting it work, but this is consistent with aws_db_instance. If this is the wrong approach, I can use a validator instead.

I've also updated all the tests to include uppercase letters, which might be overkill.

[slothelle]

just a quick documentation nit and then backs away slowly from go

[thrashr888]

@feministy Unless I'm missing something, I think you forgot to add whatever comment you meant to there. :) What's the nit?

[slothelle]

@thrashr888 it's inline with the review comments

.... that i didnt submit, thanks github

[slothelle]

i might note here why it's converted to lowercase so users aren't like "?????"

[apparentlymart]

Looks good to me!

Agreed with @feministy that we should clarify that this is done because RDS itself requires the value to be lowercase.

After that, assuming the acceptance tests are passing for this, merge away!

[apparentlymart]

(Oh, and when you do merge, remember to add a note about this to CHANGELOG.md, which you can do by editing it in the github web UI.)

[thrashr888]

Thanks guys!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.