Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elastic_beanstalk_environment wait_for_ready_timeout documentation wrong #14148

Closed
archgrove opened this issue May 2, 2017 · 2 comments
Closed

Comments

@archgrove
Copy link
Contributor

archgrove commented May 2, 2017

Version

0.9.3

Affected Resource(s)

AWS elastic_beanstalk_environment

Description

Commit cd79471 (for PR #13359) altered the default wait_for_ready_timeout on EB instances from 10 to 20 minutes, but did not update the documentation to reflect this.

I've two solutions:

  1. A trivial PR at that corrects the documentation: Make wait_for_ready_timeout default match code #14149
  2. Revert cd79471ecbad41b8bb9e70cc5e8e47b210cc3f32: As it stands, it'll cause everyone using the default timeout to have an unexpected change in their next plan. The change was done in reference to provider/aws: Increase Beanstalk env 'ready' timeout #13359, and fixes a test failure to due (I assume) overrunning EB waits, but seems like a blunt instrument. I've not looked in detail, so it might well be the most sensible thing to do, but the knock-on effect to end users is a bit sad. However, it might be too late, as this went out in 0.9.3?
@radeksimko
Copy link
Member

Fixed via #14149

I'll make sure to think about graceful migration paths next time.
Sorry if it caused any inconvenience.

@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants