providers/aws: don't force update for existing launch configs #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisferry if you get the chance do you think you could retry from this branch? I think your LCs should be |
|
@phinze thanks for fixing my mistake. The Alias record PR is getting a lot more testing. ;-) |
These changes should fix #1367: * `ebs_optimized` gets `Computed: true` and set from `Read` * `ephemeral_block_device` loses `Computed: true` * explicitly set `root_block_device` to empty from `Read` While I was in there (tm): * Send pointers to `d.Set` so we can use its internal nil check.
phinze
force-pushed
the
b-aws-launch-config-forced-update
branch
from
3a94bcb to
9a91e10
Compare
|
👍 |
phinze
added a commit
that referenced
this pull request
Apr 6, 2015
…date providers/aws: don't force update for existing launch configs
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should fix #1367:
ebs_optimizedgetsComputed: trueand set fromReadephemeral_block_devicelosesComputed: trueroot_block_deviceto empty fromReadWhile I was in there (tm):
d.Setso we can use its internal nil check.