Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/alicloud: Fix create PrePaid instance (#13661) #13662

Merged

Conversation

pragkent
Copy link
Contributor

Fix creating PrePaid instance error

Use different IoOptimized value for PrePaid instance and PostPaid instance

Fixes: #13661

@pragkent
Copy link
Contributor Author

make testacc TEST=./builtin/providers/alicloud TESTARGS=-run='TestAccAlicloudInstance_basic'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/14 19:42:20 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/alicloud -v -run=TestAccAlicloudInstance_basic -timeout 120m
=== RUN TestAccAlicloudInstance_basic
--- PASS: TestAccAlicloudInstance_basic (102.24s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/alicloud 102.259s

@pragkent
Copy link
Contributor Author

I have successfully created a few PrePaid instances with modified code.

Since the PrePaid instance is far more expensive to create and it will exist for a month, I think it might not be a good idea to create a automated test case for this. So I just run the basic test case to make sure the PostPaid instances do not complain about it.

If you need anything else, please let me know.

@stack72
Copy link
Contributor

stack72 commented Apr 16, 2017

LGTM! Thanks for this :)

@stack72 stack72 merged commit 4c25e1e into hashicorp:master Apr 16, 2017
@pragkent pragkent deleted the provider-alicloud-fix-prepaid-instance branch April 19, 2017 11:41
@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider/alicloud: failed to create PrePaid alicloud_instance
3 participants