Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/azurerm: Event Hubs making the Location field idempotent #13570

Merged
merged 3 commits into from
Apr 12, 2017

Conversation

tombuildsstuff
Copy link
Contributor

Fixes a bug where the Location field caused a perpectual diff, with the Read function normalising the location and the Schema not - reported by @lstolyarov at the London HUG for Event Hub Authorization Rules (and Consumer Groups)

Tests pass:

$ envchain azurerm make testacc TEST=./builtin/providers/azurerm/ TESTARGS='-run=TestAccAzureRMEventHubConsumerGroup'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/12 11:09:25 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/azurerm/ -v -run=TestAccAzureRMEventHubConsumerGroup -timeout 120m
=== RUN   TestAccAzureRMEventHubConsumerGroup_importBasic
--- PASS: TestAccAzureRMEventHubConsumerGroup_importBasic (356.07s)
=== RUN   TestAccAzureRMEventHubConsumerGroup_importComplete
--- PASS: TestAccAzureRMEventHubConsumerGroup_importComplete (358.80s)
=== RUN   TestAccAzureRMEventHubConsumerGroup_basic
--- PASS: TestAccAzureRMEventHubConsumerGroup_basic (348.86s)
=== RUN   TestAccAzureRMEventHubConsumerGroup_complete
--- PASS: TestAccAzureRMEventHubConsumerGroup_complete (357.12s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/azurerm	1420.863s
$ envchain azurerm make testacc TEST=./builtin/providers/azurerm/ TESTARGS='-run=TestAccAzureRMEventHubAuthorization'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/12 11:09:26 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/azurerm/ -v -run=TestAccAzureRMEventHubAuthorization -timeout 120m
=== RUN   TestAccAzureRMEventHubAuthorizationRule_importListen
--- PASS: TestAccAzureRMEventHubAuthorizationRule_importListen (340.31s)
=== RUN   TestAccAzureRMEventHubAuthorizationRule_importSend
--- PASS: TestAccAzureRMEventHubAuthorizationRule_importSend (352.71s)
=== RUN   TestAccAzureRMEventHubAuthorizationRule_importReadWrite
--- PASS: TestAccAzureRMEventHubAuthorizationRule_importReadWrite (347.81s)
=== RUN   TestAccAzureRMEventHubAuthorizationRule_importManage
--- PASS: TestAccAzureRMEventHubAuthorizationRule_importManage (374.06s)
=== RUN   TestAccAzureRMEventHubAuthorizationRule_listen
--- PASS: TestAccAzureRMEventHubAuthorizationRule_listen (378.14s)
=== RUN   TestAccAzureRMEventHubAuthorizationRule_send
--- PASS: TestAccAzureRMEventHubAuthorizationRule_send (357.69s)
=== RUN   TestAccAzureRMEventHubAuthorizationRule_readwrite
--- PASS: TestAccAzureRMEventHubAuthorizationRule_readwrite (356.87s)
=== RUN   TestAccAzureRMEventHubAuthorizationRule_manage
--- PASS: TestAccAzureRMEventHubAuthorizationRule_manage (382.39s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/azurerm	2890.012s

Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tombuildsstuff tombuildsstuff merged commit 8493155 into master Apr 12, 2017
@tombuildsstuff tombuildsstuff deleted the azurerm-eventhub-location branch April 12, 2017 11:33
tombuildsstuff added a commit that referenced this pull request Apr 12, 2017
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants