provider/aws: Fix panic on nil route configs #13548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an `aws_route_table`, if a `route` configuration block is left `nil`, Terraform would previously panic. This allows Terraform to catch a faulty interface conversion during the resource create. The resource will still fail to apply, however, since every item in the `route` element is `Optional` we cannot currently catch this error during plan time, via validation. Fixes: #13545
apparentlymart
approved these changes
Apr 11, 2017
| @@ -497,3 +513,16 @@ resource "aws_route_table" "foo" { | |||
| propagating_vgws = ["${aws_vpn_gateway.foo.id}"] | |||
| } | |||
| ` | |||
|
|
|||
| const testAccRouteTableConfigPanic = ` | |||
There was a problem hiding this comment.
Since this change fixes the panic, probably worth having a note either here or on the test above to explain that this was added to cover for an earlier bug, or else the name is somewhat confusing.
point to github issue
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an
aws_route_table, if arouteconfiguration block is leftnil, Terraform would previously panic. This allows Terraform to catch a faulty interface conversion during the resource create. The resource will still fail to apply, however, since every item in therouteelement isOptionalwe cannot currently catch this error during plan time, via validation.Fixes: #13545