Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for api_gateway_stage #13540

Merged
merged 1 commit into from
Apr 12, 2017

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Apr 11, 2017

Related to #6972

This resource (intentionally) doesn't allow changing method settings - e.g. cloudwatch metrics or logging - that's because we don't have a very good support for maps with complex values and secondly we want to be able to change method settings for stages which were created as part of aws_api_gateway_deployment, not just for new stages.

I'm will submit a separate PR for aws_api_gateway_method_settings which satisfies the mentioned need and that should eventually close #6972

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayStage_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/11 11:50:11 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayStage_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayStage_basic
--- PASS: TestAccAWSAPIGatewayStage_basic (539.63s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	539.659s

Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit 5f02c0b into master Apr 12, 2017
@radeksimko radeksimko deleted the f-aws-api-gateway-stage branch April 12, 2017 07:35
fatmcgav pushed a commit to fatmcgav/terraform that referenced this pull request Apr 12, 2017
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aws_api_gateway_stage to allow enabling CloudWatch metrics per method
2 participants