Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provisioner/chef: make sure we add new Chef-Vault clients as clients #13525

Merged
merged 1 commit into from
Apr 11, 2017
Merged

provisioner/chef: make sure we add new Chef-Vault clients as clients #13525

merged 1 commit into from
Apr 11, 2017

Conversation

svanharmelen
Copy link
Contributor

This is possible using the newly released Chef-Vault 3.0 gem. Before we could only add new clients as admins.

Fixes #9137

This is possible using the newly released Chef-Vault 3.0 gem. Before we could only add new clients as admins.

Fixes #9137
@svanharmelen
Copy link
Contributor Author

@radeksimko if you could have a quick look? This is a very small fix, but we had to wait a long time to get my changes to Chef-Vault released in a new gem... But that happened yesterday, so we can now fix/improve this one 😀

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of wish we had acceptance tests for provisioners too (actually provisioning real instance), but this LGTM.

@svanharmelen
Copy link
Contributor Author

Thanks for the review @radeksimko!

@svanharmelen svanharmelen merged commit 7304fe5 into hashicorp:master Apr 11, 2017
@svanharmelen svanharmelen deleted the b-chef-vaults branch April 11, 2017 09:18
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with vault_json implementation for chef provisioner
2 participants