provider/aws: Add support for aws_lightsail_static_ip

[radeksimko]

Related: #10447

I'll submit aws_lightsail_static_ip_attachment too and that should hopefully allow us to close the mentioned issue and satisfy Lightsail users for a while.

There's a potential for a few more resources based on the current API, but I'd close that issue anyway, otherwise it will have no end. People can always submit PRs for those if they wish.

• aws_lightsail_domain_entry
• aws_lightsail_public_port

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSLightsailStaticIp'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/29 21:23:40 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSLightsailStaticIp -timeout 120m
=== RUN   TestAccAWSLightsailStaticIp_basic
--- PASS: TestAccAWSLightsailStaticIp_basic (19.12s)
=== RUN   TestAccAWSLightsailStaticIp_disappears
--- PASS: TestAccAWSLightsailStaticIp_disappears (13.50s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	32.662s

[stack72]

@radeksimko LGTM pending 1 small question :)

[stack72]

If the static IP is in use by an instance, will this release API call work? Or will it fail?

[radeksimko]

Good question, I just tested this situation and the releasing just succeeded. Admittedly I'd expect and like it to fail (and implement something like force_destroy (bool) to override it), but there isn't much we can do about this as that's how the API works.

[stack72]

In that case, LGTM :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.