Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/azurerm: Network Security Group - ignoring protocol casing at Import time #13153

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Mar 29, 2017

Fixes #13085 - when importing a Network Security Group, the Protocol this PR ignores the casing on the Protocol field

Tests pass:

 $ envchain azurerm make testacc TEST=./builtin/providers/azurerm/ TESTARGS='-run=TestAccAzureRMNetworkSecurityGroup'
TF_ACC=1 go test ./builtin/providers/azurerm/ -v -run=TestAccAzureRMNetworkSecurityGroup -timeout 120m
=== RUN   TestAccAzureRMNetworkSecurityGroup_importBasic
--- PASS: TestAccAzureRMNetworkSecurityGroup_importBasic (113.06s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_basic
--- PASS: TestAccAzureRMNetworkSecurityGroup_basic (109.59s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_disappears
--- PASS: TestAccAzureRMNetworkSecurityGroup_disappears (107.92s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_withTags
--- PASS: TestAccAzureRMNetworkSecurityGroup_withTags (136.80s)
=== RUN   TestAccAzureRMNetworkSecurityGroup_addingExtraRules
--- PASS: TestAccAzureRMNetworkSecurityGroup_addingExtraRules (144.80s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/azurerm	612.193s

@amcguign
Copy link

Thanks Tom, appreciate the super-quick turnaround on this little one!

@stack72 stack72 merged commit 25da340 into hashicorp:master Mar 29, 2017
@tombuildsstuff tombuildsstuff deleted the azurerm-nsg branch March 29, 2017 16:22
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants