provider/dnsimple: Handle 404 on DNSimple records #13131
Conversation
When a record was manually deleted from the console, we got an error saying 404 Record Not Found //cc @weppos This PR now handles the usecase: ``` % make testacc TEST=./builtin/providers/dnsimple ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/03/28 21:48:19 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/dnsimple -v -timeout 120m === RUN TestProvider --- PASS: TestProvider (0.00s) === RUN TestProvider_impl --- PASS: TestProvider_impl (0.00s) === RUN TestAccDNSimpleRecord_Basic --- PASS: TestAccDNSimpleRecord_Basic (1.81s) === RUN TestAccDNSimpleRecord_CreateMxWithPriority --- PASS: TestAccDNSimpleRecord_CreateMxWithPriority (1.32s) === RUN TestAccDNSimpleRecord_Updated --- PASS: TestAccDNSimpleRecord_Updated (4.46s) === RUN TestAccDNSimpleRecord_disappears --- PASS: TestAccDNSimpleRecord_disappears (1.20s) === RUN TestAccDNSimpleRecord_UpdatedMx --- PASS: TestAccDNSimpleRecord_UpdatedMx (2.91s) PASS ok github.com/hashicorp/terraform/builtin/providers/dnsimple 11.723s ```
| @@ -104,6 +105,11 @@ func resourceDNSimpleRecordRead(d *schema.ResourceData, meta interface{}) error | |||
|
|
|||
| resp, err := provider.client.Zones.GetRecord(provider.config.Account, d.Get("domain").(string), recordID) | |||
| if err != nil { | |||
| if err != nil && strings.Contains(err.Error(), "404") { | |||
There was a problem hiding this comment.
Is there a reason for repeating if err != nil?
Also, this line reminds me we probably have to improve the error reporting in case of 404. Checking against the 404 string is quite error-prone. I can't recall on the top of my head if there is a better way to handle it, I'll check it by tomorrow.
There was a problem hiding this comment.
@weppos any luck with the SDK?
radeksimko
added
the
waiting-response
stack72
removed
the
waiting-response
|
@weppos any thoughts on this? |
|
Sorry, a couple of other priorities stepped in. I apologize for the delay, I didn't have the time to check yet. I am fine to merge to avoid locking the PR. I will provide an update if I can find a better way, assuming the SDK supports it (or after we add support for 404 specific error types). |
|
Thanks @weppos we will merge this in it's current state and then improve later :) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
When a record was manually deleted from the console, we got an error
saying 404 Record Not Found
//cc @weppos
This PR now handles the usecase: