alicloud: simplify validators #12982
Conversation
| return | ||
| } | ||
| return | ||
| return validation.IntBetween(1, 65535)(v, k) |
There was a problem hiding this comment.
Is there a reason the validation functions are wrapped rather than being used directly in the schema? Seems to create a lot of redundant functions.
There was a problem hiding this comment.
mostly because there are a ton of tests, and I wanted to be certain that all of these worked correctly before inlining.
speaking of which, any thoughts on how to test the validation functions after I inline them? seems overkill to actually create full HCL test data for each variant.
There was a problem hiding this comment.
Makes sense.
Where the validation functions are used in the azurerm provider there are no tests, we trust that the validation package itself is tested properly.
There was a problem hiding this comment.
LGTM! Thanks for the work here @josephholsten and thanks for the review @pmcatominey
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
No description provided.