-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Increase AMI destroy timeout #12943
Conversation
Acceptance tests were timing out on AMI destroy, should alleviate the problem.
|
resource.TestStep{ | ||
Config: testAccAWSAMIFromInstanceConfig, | ||
{ | ||
Config: fmt.Sprintf(testAccAWSAMIFromInstanceConfig, rInt), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually wrap these in a function, merely to avoid test failures and confusions caused by reusing such configs and forgetting to pass the integer. Function with argument can enforce this at compilation time, which is nice.
With all that said it's probably a nitpick. :)
* provider/aws: Increase AMI destroy timeout Acceptance tests were timing out on AMI destroy, should alleviate the problem. * Further increase timeout, cleanup test * use function instead of printf
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Acceptance tests were timing out on AMI destroy, should alleviate the problem.