Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/ns1: Add notify list resource #12373

Merged
merged 8 commits into from
Mar 5, 2017
Merged

Conversation

pashap
Copy link
Contributor

@pashap pashap commented Mar 2, 2017

Adds:

  • Notify List resource (impl, docs, acctests)
  • Ability to set ns1 rest api endpoint and ignore ssl cert for local development within ns1
  • Few more test cases around Monitoring Job resource

Updates:

  • ns1 go rest client package (via govendor)

@stack72
Copy link
Contributor

stack72 commented Mar 5, 2017

LGTM! Thanks for this :)

@stack72
Copy link
Contributor

stack72 commented Mar 5, 2017

% make testacc TEST=./builtin/providers/ns1
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/05 16:15:22 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/ns1 -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccDataFeed_basic
--- PASS: TestAccDataFeed_basic (31.82s)
=== RUN   TestAccDataFeed_updated
--- PASS: TestAccDataFeed_updated (26.97s)
=== RUN   TestAccDataSource_basic
--- PASS: TestAccDataSource_basic (6.76s)
=== RUN   TestAccDataSource_updated
--- PASS: TestAccDataSource_updated (15.76s)
=== RUN   TestAccMonitoringJob_basic
--- PASS: TestAccMonitoringJob_basic (7.14s)
=== RUN   TestAccMonitoringJob_updated
--- PASS: TestAccMonitoringJob_updated (14.80s)
=== RUN   TestAccNotifyList_basic
--- PASS: TestAccNotifyList_basic (7.36s)
=== RUN   TestAccNotifyList_updated
--- PASS: TestAccNotifyList_updated (9.63s)
=== RUN   TestAccRecord_basic
--- PASS: TestAccRecord_basic (16.38s)
=== RUN   TestAccRecord_updated
--- PASS: TestAccRecord_updated (21.17s)
=== RUN   TestAccTeam_basic
--- PASS: TestAccTeam_basic (6.64s)
=== RUN   TestAccTeam_updated
--- PASS: TestAccTeam_updated (9.14s)
=== RUN   TestAccZone_basic
--- PASS: TestAccZone_basic (8.27s)
=== RUN   TestAccZone_updated
--- PASS: TestAccZone_updated (12.56s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/ns1	194.415s

@stack72 stack72 merged commit ce633f2 into hashicorp:master Mar 5, 2017
stack72 pushed a commit that referenced this pull request Mar 5, 2017
* Allow for local development with ns1 provider.

* Adds first implementation of ns1 notification list resource.

* NS1 record.use_client_subnet defaults to true, and added test for field.

* Adds more test cases for monitoring jobs.

* Adds webhook/datafeed notifier types and acctests for notifylists.

* Adds docs for notifylists resource.

* Updates ns1-go rest client via govendor

* Fix typos in record docs
yanndegat pushed a commit to yanndegat/terraform that referenced this pull request Mar 13, 2017
* Allow for local development with ns1 provider.

* Adds first implementation of ns1 notification list resource.

* NS1 record.use_client_subnet defaults to true, and added test for field.

* Adds more test cases for monitoring jobs.

* Adds webhook/datafeed notifier types and acctests for notifylists.

* Adds docs for notifylists resource.

* Updates ns1-go rest client via govendor

* Fix typos in record docs
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants