Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the certificate ID in the IAM server certificate data source #11693

Conversation

w32-blaster
Copy link
Contributor

@w32-blaster w32-blaster commented Feb 4, 2017

ID is used in aws cloudfront distributions and probably in other aws resources as well

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDataSourceIAMServerCertificate_basic -timeout 120m
=== RUN   TestAccAWSDataSourceIAMServerCertificate_basic
--- PASS: TestAccAWSDataSourceIAMServerCertificate_basic (21.55s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	21.570s

ID is used in aws cloudfront distributions and probably in other aws resources as well
@stack72
Copy link
Contributor

stack72 commented Feb 4, 2017

Hi @w32-blaster

Thanks for the work here - this LGTM! I will add the new param to the docs

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDataSourceIAMServerCertificate_basic'                                   ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/04 13:32:12 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDataSourceIAMServerCertificate_basic -timeout 120m
=== RUN   TestAccAWSDataSourceIAMServerCertificate_basic
--- PASS: TestAccAWSDataSourceIAMServerCertificate_basic (23.34s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	23.383s

Paul

@stack72 stack72 merged commit e001eca into hashicorp:master Feb 4, 2017
stack72 pushed a commit that referenced this pull request Feb 4, 2017
ID is used in aws cloudfront distributions and probably in other aws resources as well
@apparentlymart apparentlymart changed the title Provide the certificate ID in the aws data source Provide the certificate ID in the IAM server certificate data source Feb 4, 2017
arcadiatea pushed a commit to ticketmaster/terraform that referenced this pull request Feb 9, 2017
ID is used in aws cloudfront distributions and probably in other aws resources as well
@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants