Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: ECS Placement constraints fix #11475

Merged
merged 6 commits into from
Jan 29, 2017
Merged

provider/aws: ECS Placement constraints fix #11475

merged 6 commits into from
Jan 29, 2017

Conversation

grubernaut
Copy link
Contributor

Expands upon #11446 from @bgetsug

Adds:

  • Acceptance Test
  • Improves nil check on constraint expression

Fixes: #10968

Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :) Thanks to @grubernaut and @bgetsug

@stack72 stack72 merged commit 96f6044 into master Jan 29, 2017
@stack72 stack72 deleted the pr-11446 branch January 29, 2017 16:42
stack72 pushed a commit that referenced this pull request Jan 29, 2017
* fixing AWS ECS placement constraints

* correcting AWS ECS task definition doc

* reverting unnecessary change to resource_aws_ecs_task_definition

* provider/aws: ECS Placement constraints fix

Expands upon #11446 from @bgetsug

Adds:
 - Acceptance Test
 - Improves `nil` check on constraint expression

 Fixes: #10968
arcadiatea pushed a commit to ticketmaster/terraform that referenced this pull request Feb 9, 2017
* fixing AWS ECS placement constraints

* correcting AWS ECS task definition doc

* reverting unnecessary change to resource_aws_ecs_task_definition

* provider/aws: ECS Placement constraints fix

Expands upon hashicorp#11446 from @bgetsug

Adds:
 - Acceptance Test
 - Improves `nil` check on constraint expression

 Fixes: hashicorp#10968
@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws]ECS Task placement
2 participants